[Merge] lp:~uriboni/webbrowser-app/qml-tabs-model into lp:webbrowser-app

Olivier Tilloy olivier.tilloy at canonical.com
Mon Nov 9 08:50:52 UTC 2015


> It is really odd that this was working on jenkins, but not when we run
> it on our machines. Fixed in any case

As I explained in a comment on another merge request, CI didn’t complain because it doesn’t run autopilot tests on desktop, only on a phone.


> I mean that -1 stops being a valid index when the model is not empty.
> But removed "anymore" to avoid confusion anyway.

Right, I had misunderstood the comment. It was slightly confusing (or maybe it was just me who was confused). Thanks for clarifying!
-- 
https://code.launchpad.net/~uriboni/webbrowser-app/qml-tabs-model/+merge/270408
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list