[Merge] lp:~uriboni/webbrowser-app/undo-close-tab into lp:webbrowser-app

Ugo Riboni ugo.riboni at canonical.com
Sun Nov 8 23:14:12 UTC 2015


> At least the following two tests are failing on my desktop:
> 
>   webbrowser_app.tests.test_tabs.TestTabsFocus.test_focus_on_close
>   webbrowser_app.tests.test_tabs.TestTabsFocus.test_focus_on_switch
> 
> It looks like Ctrl+T doesn’t work any longer to open a new tab (at least in
> the tests, it seems to work fine when I run the app).

We had the same problem in the qml-tabs-model MR, and I fixed the problem already there. Given that this code presumably will go in the same silo, and that CI seems to be happy about the tests anyway (why ?), can we avoid fixing this here too and then having to solve the conflict ?


-- 
https://code.launchpad.net/~uriboni/webbrowser-app/undo-close-tab/+merge/275849
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list