[Merge] lp:~phablet-team/qtubuntu-media/fix-1510221 into lp:qtubuntu-media/stable

Jim Hodapp jim.hodapp at canonical.com
Fri Nov 6 18:38:13 UTC 2015


> Looks good, although I do not agree that we are thread-safe just because we
> change the LUT before calling media-hub. We need a explicit locking mechanism
> for that. Said this, anyway we need to rethink a bit how to make sure we are
> synchronous, as discussed. So I won't stop this for landing ;)

I agree that we're not 100%, but I'm talking about in this specific scenario. If I put the modification of the track_index_lut before the call to move_track to media-hub, or in the on_track_moved() signal handler, then it's not thread safe. But having the modification before the media-hub call ensures for this specific case that only one thread will be modifying it. If anything else is modifying it, it's not because of the moving of the track scenario but is instead a different one that needs to be tweaked.
-- 
https://code.launchpad.net/~phablet-team/qtubuntu-media/fix-1510221/+merge/276559
Your team Ubuntu Phablet Team is subscribed to branch lp:~phablet-team/qtubuntu-media/bg-playlist-fixes.



More information about the Ubuntu-reviews mailing list