[Merge] lp:~uriboni/webbrowser-app/qml-tabs-model into lp:webbrowser-app

Olivier Tilloy olivier.tilloy at canonical.com
Wed Nov 4 10:55:09 UTC 2015


Review: Needs Fixing

There is one extraneous blank line in updateCurrentTab, can it be removed?

In insert(), if index is invalid, shouldn’t the fuction return early after printing out the warning? And in test_shouldNotInsertTabAtInvalidIndex, you should also verify that currentIndex and currentTab remain unchanged.

Should we really allow setting currentIndex to -1 when there’s at least one tab in the model? What real-world use case does this cover?
-- 
https://code.launchpad.net/~uriboni/webbrowser-app/qml-tabs-model/+merge/270408
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list