[Merge] lp:~brian-murray/ubuntu-release-upgrader/remove-mirrors into lp:ubuntu-release-upgrader

[Brian Murray]

Brian Murray has proposed merging lp:~brian-murray/ubuntu-release-upgrader/remove-mirrors into lp:ubuntu-release-upgrader.

Requested reviews:
  Ubuntu Core Development Team (ubuntu-core-dev)
Related bugs:
  Bug #1463680 in ubuntu-release-upgrader (Ubuntu): "mirrors only added to mirrors.cfg, never removed"
  https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1463680

For more details, see:
https://code.launchpad.net/~brian-murray/ubuntu-release-upgrader/remove-mirrors/+merge/276412

The pre-build script for ubuntu-release-upgrader runs some code to update the mirrors.cfg file which contains the official ubuntu mirrors and is used for verifying the client's sources.list file. However, that code only adds new mirrors and never removes mirrors that are no longer valid.

Looking at the mirrors.cfg file it seems to first have been manually created with the first 23 lines being permanent and then divided into country sections. The update code only ever appends mirrors, but I thought it was worth keeping country sections so have done that in this merge proposal. This may end up creating country sections w/o any mirrors but those could be removed manually.

This should not be merged until bug 1511783 is fixed.
-- 
Your team Ubuntu Core Development Team is requested to review the proposed merge of lp:~brian-murray/ubuntu-release-upgrader/remove-mirrors into lp:ubuntu-release-upgrader.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 34594 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20151102/84d18957/attachment-0001.diff>