[Merge] lp:~osomon/webbrowser-app/newTabRefactoring-autopilot-tests into lp:webbrowser-app

Olivier Tilloy olivier.tilloy at canonical.com
Fri May 29 09:49:58 UTC 2015


> Some things:
> 
> -                onHistoryDomainRemoved:
> browser.historyModel.removeEntriesByDomain(domain)
> 
> Why do you remove the possibilty to delete an entire domain? Anyway, if you
> are sure about this, you should also remove the swype - atm you can swype the
> domain, but then when you click on the trash icon nothing happens.

Good catch! This is something I overlooked, I just pushed a new revision that fixes it.


> In the ExpandedHistoryView there isn't anymore the multiple selection - I
> think we should be consistent and have it (or don't have it) both in
> ExpandedHistoryView and HistoryView

We never had multiple selection in the expanded history view, so this is not a regression. If you think we should have it, feel free to file a bug against webbrowser-app and ubuntu-ux to have design comment on the idea.
-- 
https://code.launchpad.net/~osomon/webbrowser-app/newTabRefactoring-autopilot-tests/+merge/260488
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list