[Merge] lp:~nobuto/ubuntu/vivid/unzip/fallback-encoding into lp:ubuntu/unzip

Nobuto Murata nobuto at nobuto-murata.org
Fri May 29 06:51:21 UTC 2015


The branch has been rebased on the wily package. To address concerns about regressions, I have added autopkgtest to make sure all of 3 types of zip files can be handled correctly.

Can you please review this again?

#### autopkgtest w/o fallback

adt-run [15:50:02]: test fallback-encoding: [-----------------------
Archive:  unx-utf8/test.zip
Zip file size: 416 bytes, number of entries: 2
drwxrwxr-x  3.0 unx        0 bx stor 15-May-29 00:50 テストフォルダ/
-rw-rw-r--  3.0 unx        0 bx stor 15-May-28 15:32 テストフォルダ/テストファイル.txt
2 files, 0 bytes uncompressed, 0 bytes compressed:  0.0%
Archive:  unx-utf8/test.zip
   creating: unx-utf8/テストフォルダ/
 extracting: unx-utf8/テストフォルダ/テストファイル.txt  
extract unx-utf8: OK

Archive:  fat-utf8/test.zip
Zip file size: 322 bytes, number of entries: 1
-rw----     2.0 fat        0 bX defN 15-May-28 09:01 テストフォルダ/テストファイル.txt
1 file, 0 bytes uncompressed, 2 bytes compressed:  0.0%
Archive:  fat-utf8/test.zip
  inflating: fat-utf8/テストフォルダ/テストファイル.txt  
extract fat-utf8: OK

Archive:  fat-cp932/test.zip
Zip file size: 164 bytes, number of entries: 1
-rw-a--     2.0 fat        0 b- stor 15-May-28 15:32 ГeГXГgГtГHГЛГ_/ГeГXГgГtГ@ГCГЛ.txt
1 file, 0 bytes uncompressed, 0 bytes compressed:  0.0%
Archive:  fat-cp932/test.zip
 extracting: fat-cp932/ГeГXГgГtГHГЛГ_/ГeГXГgГtГ@ГCГЛ.txt  
stat: cannot stat ‘fat-cp932/テストフォルダ/テストファイル.txt’: No such file or directory
adt-run [15:50:02]: test fallback-encoding: -----------------------]
adt-run [15:50:03]: test fallback-encoding:  - - - - - - - - - - results - - - - - - - - - -
fallback-encoding    FAIL non-zero exit status 1
adt-run [15:50:04]: test fallback-encoding:  - - - - - - - - - - stderr - - - - - - - - - -
stat: cannot stat ‘fat-cp932/テストフォルダ/テストファイル.txt’: No such file or directory


#### autopkgtest w/ fallback

adt-run [15:40:49]: test fallback-encoding: [-----------------------
Archive:  unx-utf8/test.zip
Zip file size: 416 bytes, number of entries: 2
drwxrwxr-x  3.0 unx        0 bx stor 15-May-29 00:50 テストフォルダ/
-rw-rw-r--  3.0 unx        0 bx stor 15-May-28 15:32 テストフォルダ/テストファイル.txt
2 files, 0 bytes uncompressed, 0 bytes compressed:  0.0%
Archive:  unx-utf8/test.zip
   creating: unx-utf8/テストフォルダ/
 extracting: unx-utf8/テストフォルダ/テストファイル.txt  
extract unx-utf8: OK

Archive:  fat-utf8/test.zip
Zip file size: 322 bytes, number of entries: 1
-rw----     2.0 fat        0 bX defN 15-May-28 09:01 テストフォルダ/テストファイル.txt
1 file, 0 bytes uncompressed, 2 bytes compressed:  0.0%
Archive:  fat-utf8/test.zip
  inflating: fat-utf8/テストフォルダ/テストファイル.txt  
extract fat-utf8: OK

Archive:  fat-cp932/test.zip
Zip file size: 164 bytes, number of entries: 1
-rw-a--     2.0 fat        0 b- stor 15-May-28 15:32 テストフォルダ/テストファイル.txt
1 file, 0 bytes uncompressed, 0 bytes compressed:  0.0%
Archive:  fat-cp932/test.zip
 extracting: fat-cp932/テストフォルダ/テストファイル.txt  
extract fat-cp932: OK

adt-run [15:40:50]: test fallback-encoding: -----------------------]
adt-run [15:40:51]: test fallback-encoding:  - - - - - - - - - - results - - - - - - - - - -
fallback-encoding    PASS

-- 
https://code.launchpad.net/~nobuto/ubuntu/vivid/unzip/fallback-encoding/+merge/258824
Your team Ubuntu branches is subscribed to branch lp:ubuntu/unzip.



More information about the Ubuntu-reviews mailing list