[Merge] lp:~rpadovani/webbrowser-app/remove-404-history into lp:webbrowser-app

[Olivier Tilloy]

Review: Needs Fixing

That’s better, still a couple of issues:

157	+        delegates = expanded_history.select_many("entriesDelegate")

This should be .select_many("UrlDelegate", objectName="entriesDelegate")


158	+        # 2 addresses: /test1 and /test2
159	+        self.assertThat(lambda: len(delegates), Eventually(Equals(2)))

This lambda won’t work: delegates is not updated, so len(delegates) will never change. What you really want to do is:

    self.assertThat(lambda: len(expanded_history.select_many(…)), Eventually(Equals(2)))


161	+        self.assertThat(delegates[0].url, Equals(self.url))

Here instead of testing only the first delegate, you should probably loop over the two delegates and verify that one of them has self.url, and the other one has url ("/test1" and "/test2").
-- 
https://code.launchpad.net/~rpadovani/webbrowser-app/remove-404-history/+merge/259313
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.