[Merge] lp:~uriboni/webbrowser-app/keyboard-navigation into lp:webbrowser-app

Ugo Riboni ugo.riboni at canonical.com
Tue May 26 15:57:27 UTC 2015


Ugo Riboni has proposed merging lp:~uriboni/webbrowser-app/keyboard-navigation into lp:webbrowser-app with lp:~rpadovani/webbrowser-app/newTabRefactoring as a prerequisite.

Commit message:
Make the browser chrome usable on desktop by implementing common keyboard shortcuts and behaviors that users normally expect in such an app

Requested reviews:
  Ubuntu Phablet Team (phablet-team)

For more details, see:
https://code.launchpad.net/~uriboni/webbrowser-app/keyboard-navigation/+merge/260183

The goal of this merge request is to make the browser chrome usable on desktop by implementing common keyboard shortcuts and behaviors that users normally expect in such an app.
Some come directly from the design document and some have been added based on what is obvious and intuitive (and already by other browsers).

This is based on, and supersedes, the following contributor branch: https://code.launchpad.net/~gang65/webbrowser-app/webbrowser-app-keyboard-shortcuts due to the original contributor not replying to requests on the MR in time.

It is also based on this refactoring branch: https://code.launchpad.net/~rpadovani/webbrowser-app/newTabRefactoring/+merge/247498

Finally it also supersedes this branch adding keyboard support to the suggestions list, as it is essentially a superset of that work so they might as well go together: https://code.launchpad.net/~uriboni/webbrowser-app/suggestions-keyboard-navigation


-- 
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~uriboni/webbrowser-app/keyboard-navigation into lp:webbrowser-app.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 31630 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20150526/6233bfa9/attachment-0001.diff>


More information about the Ubuntu-reviews mailing list