[Merge] lp:~rpadovani/webbrowser-app/newTabRefactoring into lp:webbrowser-app

Olivier Tilloy olivier.tilloy at canonical.com
Thu May 21 10:13:14 UTC 2015


After some deep investigation, I finally nailed where the issue is: the problem is that oxide’s WebView.restoreState will always return an empty string (see http://bazaar.launchpad.net/~oxide-developers/oxide/oxide.trunk/view/head:/qt/quick/api/oxideqquickwebview.cc#L1606). So !currentWebview.restoreState will always be true. Instead we need to check the value of restoreState on the tab object.

Also one note that will simplify the code: instead of setting sourceComponent conditionally on the Loader, we can set it once, and then toggle the 'active' property of the loader.

I produced a patch that does those two things and should apply cleanly on top of your branch: http://pastebin.ubuntu.com/11261520/.
-- 
https://code.launchpad.net/~rpadovani/webbrowser-app/newTabRefactoring/+merge/247498
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list