[Merge] lp:~akulichalexander/telepathy-ofono/telepathy-ofono into lp:telepathy-ofono

Alexander Akulich akulichalexander at gmail.com
Thu May 21 02:27:20 UTC 2015


I released the tarball days ago.

http://telepathy.freedesktop.org/releases/telepathy-qt/telepathy-qt-0.9.6.tar.gz

If you mean
https://code.launchpad.net/~tiagosh/telepathy-ofono/update-tp-qt-api , then
it's outdated.
We removed extra arguments from createChannel(), added matchChannel()
virtual method to extend ensureChannel() behavior and refactored handle
arguments in the BaseChannel constructor.

I didn't make the changes to be 0.9.5-compatible, because the CM seems to
depend on your own TpQt fork.
The changes can be wrapped with #ifdef TP_QT_VERSION to keep compatibility.


On Thu, May 21, 2015 at 1:51 AM, Tiago Salem Herrmann <
tiago.herrmann at canonical.com> wrote:

> Hi,
>
> thanks for the patch.
> I have a branch for this port locally, but haven't submitted yet because
> the new telepathy-qt5 0.9.6 is still not present in the archive. I will
> compare your code with mine asap, but I believe it's pretty much the same
> changes.
>
> Thank you.
> --
>
> https://code.launchpad.net/~akulichalexander/telepathy-ofono/telepathy-ofono/+merge/259379
> You are the owner of lp:~akulichalexander/telepathy-ofono/telepathy-ofono.
>

-- 
https://code.launchpad.net/~akulichalexander/telepathy-ofono/telepathy-ofono/+merge/259379
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~akulichalexander/telepathy-ofono/telepathy-ofono into lp:telepathy-ofono.



More information about the Ubuntu-reviews mailing list