[Merge] lp:~artmello/webbrowser-app/webbrowser-app-private_browsing into lp:webbrowser-app

Olivier Tilloy olivier.tilloy at canonical.com
Wed May 20 13:32:37 UTC 2015


Looks good now, thanks for your work on this. Just a couple of minor comments, and we should be good to merge:

The privateTabsModel property can simply be set to privateTabsModelLoader.item (because when the loader is not ready, item will be null anyway). Given that this simplifies quite a lot its expression, the usefulness of this property is questionable. Can it be removed and its occurences (2 if I count correctly) replaced by "privateTabsModelLoader.item" ?

In privateTabsModelLoader, when !browser.incognito, the sourceComponent property should be set to undefined, not null (see http://doc.qt.io/qt-5/qml-qtquick-loader.html#sourceComponent-prop).
-- 
https://code.launchpad.net/~artmello/webbrowser-app/webbrowser-app-private_browsing/+merge/259388
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list