[Merge] lp:~artmello/webbrowser-app/webbrowser-app-private_browsing into lp:webbrowser-app
Olivier Tilloy
olivier.tilloy at canonical.com
Tue May 19 16:31:30 UTC 2015
Review: Needs Fixing
In Browser.qml:
- in onTabsModelChanged, the second if block is unnecessary, as the openUrlInNewTab() function already takes care of that
- the text for the drawer entry, according to the visual spec, should be "Private mode" and "Leave Private mode".
- there is a "private-tab-new" icon in the theme, so the icon in the drawer for the "New Tab" entry should be updated while in private mode
--
https://code.launchpad.net/~artmello/webbrowser-app/webbrowser-app-private_browsing/+merge/259388
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.
More information about the Ubuntu-reviews
mailing list