[Merge] lp:~rpadovani/webbrowser-app/remove-404-history into lp:webbrowser-app

[Olivier Tilloy]

Review: Needs Fixing

Towards the top of src/app/webbrowser/Browser.qml, please bump the import of com.canonical.Oxide to 1.8 too.


In my tests, the following two-comparisons-in-one doesn’t seem to work:

    (300 > event.httpStatusCode >= 200)

You’ll probably need to rewrite it as two comparisons.


Also it would be good to add an autopilot test for this. Something very simple that would browse to a page that doesn’t exist, which would trigger a 404, and then open the history view and verify that the URL hasn’t been stored. It doesn’t really seem to fit in any existing test file, so I would add a new file for that: tests/autopilot/webbrowser_app/tests/test_history.py.
If you don’t fancy writing that test, I’m happy doing it myself, just let me know.


-- 
https://code.launchpad.net/~rpadovani/webbrowser-app/remove-404-history/+merge/259313
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.