[Merge] lp:~artmello/webbrowser-app/webbrowser-app-private_browsing into lp:webbrowser-app

Arthur Mello arthur.mello at canonical.com
Sat May 16 02:04:13 UTC 2015


I added two new AP tests to check the issue mentioned above.

If you focus the address bar with a not empty url (the url will be selected) and go to private mode the url text will be displayed on the new private tab. That also happen if instead of going in to private mode you open a new tab (but I am not sure if that is an issue). I made a change to set the text of the address bar with the requested url even if the address bar has focus. But I would like an opinion if that is the best way to do so. The issue doesn't seem to happen anymore with this.

About the other issue I am not sure how to proper fix the issue. I tried, when changing the tabs model to the normal tabs model (returning from private mode), setting the focus to the current webview. But it seems that after that something is setting the focus in the address bar. I tried debugging and doesn't seem that the forceActiveFocus is being called for the address bar. Something else is triggering the set focus or I am missing something (or both). 
-- 
https://code.launchpad.net/~artmello/webbrowser-app/webbrowser-app-private_browsing/+merge/257673
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list