[Merge] lp:~artmello/webbrowser-app/webbrowser-app-private_browsing into lp:webbrowser-app

Olivier Tilloy olivier.tilloy at canonical.com
Fri May 15 06:04:11 UTC 2015


Review: Needs Fixing

On desktop, I’m seeing one (minor) functional issue:
 - ensure that the address bar doesn’t have focus (focus the webview)
 - open the drawer, switch to private mode (a new private tab is open, the address bar is focused)
 - open the drawer again, leave private mode, and confirm by clicking OK
 - the previous public tab is restored, but the address bar remains focused, which is unexpected (unless it was empty, but in this case it’s not)

So I think that when leaving private mode, you should check whether the address bar is empty, and if it’s not remove focus from it.
-- 
https://code.launchpad.net/~artmello/webbrowser-app/webbrowser-app-private_browsing/+merge/257673
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list