[Merge] lp:~artmello/webbrowser-app/webbrowser-app-private_browsing into lp:webbrowser-app

[Olivier Tilloy]

Review: Needs Fixing

There are two conflicts when merging this branch into the latest trunk.

The change you made to BrowserTab.qml is not sufficient: with that, no capture is ever taken, so when opening the tabs view we will get only blank tabs. What we need is to take the captures, but not store them on disk. See my previous suggestion:

> In BrowserTab.qml, instead of calling result.saveToFile(…), try
> setting preview to result.url. Hopefully, result.url is valid
> throughout the lifetime of the app. If it’s not, we might need to
> store previews on disk, but in that case we would do it under a
> different directory, and ensure that this directory is entirely
> deleted when leaving private mode, and when the app is closed/started
> (in case the app crashed and the directory wasn’t deleted).
> Another option that comes to mind (just thinking out loud here) is a
> custom image provider for tab previews, that would write files to disk
> in normal mode, and cache them in memory only in private mode. If we
> end up needing this, let’s agree to do it in a subsequent MR though.
-- 
https://code.launchpad.net/~artmello/webbrowser-app/webbrowser-app-private_browsing/+merge/257673
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.