[Merge] lp:~artmello/webbrowser-app/webbrowser-app-private_browsing into lp:webbrowser-app

Olivier Tilloy olivier.tilloy at canonical.com
Wed May 13 06:36:04 UTC 2015


> I'm still looking around to see where QA can help your sprint,
> I hope you don't mind.

Thanks for your input and active feedback Leo, that’s much appreciated!


> […] Maybe something to refactor in the future when time permits.

Agreed. See my comment on your MR.


> - the address bar sometimes disappears, which I think is what
> Arthur mentioned in a comment above.

That’s https://launchpad.net/bugs/1441064 and/or https://launchpad.net/bugs/1453908, both of which are fixed by silo 14, which is awaiting QA validation.


> - when I'm in private mode, the application is still logging some
> URLs, which kind of defeats the purpose.

Very good catch! Arthur, the onJavaScriptConsoleMessage handler will need to be overwritten when in private mode, maybe you can do that with a conditional Binding?


> I hope this helps. Our idea is to find ways to increase the value you get out
> of early testing, so if you think I'm slowing you down or making your work
> harder, by all means please let me know. Honestly :)

Please keep useful feedback like that coming :)
-- 
https://code.launchpad.net/~artmello/webbrowser-app/webbrowser-app-private_browsing/+merge/257673
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list