[Merge] lp:~uriboni/webbrowser-app/search-suggestions into lp:webbrowser-app

Olivier Tilloy olivier.tilloy at canonical.com
Tue May 12 10:33:17 UTC 2015


> It was my mistake to redefine it though, as the original can't be accessed
> any more, so I defined a new "active" property that does the same thing,
> while leaving Item.enabled alone and with its original meaning.

Yeah, that’s better and safer indeed.


> Is this a DNS mapping or a redirect of some sort ? Because it does not seem
> to work when using XmlHttpRequest from QML to get the list of suggestions.

This is oxide-specific (see Oxide.WebContext.hostMappingRules), so indeed it won’t work with XmlHttpRequest. Sorry for putting you on a false trail, I hadn’t realized the requests were not going through the WebView.


> This does not work. In some cases I get a complain from re.py of
> "unbalanced parenthesis". Unless you have a quick fix I would leave
> it as it is.

Yeah, that’s fine.
-- 
https://code.launchpad.net/~uriboni/webbrowser-app/search-suggestions/+merge/258856
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list