[Merge] lp:~sdeziel/sysvinit/early-exit-ondemand into lp:ubuntu/vivid/sysvinit

Simon Déziel simon.deziel at gmail.com
Mon May 11 20:19:58 UTC 2015


Thanks for the review Mathieu.

> This seems to me like the kind of change that should be properly documented
> with a bug report. Have you opened one regarding this matter yet? Since it
> reportedly only avoids sleeping for 60 seconds before doing nothing (exiting
> because the governors aren't available), you should describe the net effect of
> this in a bug report.

Good idea, LP: #1453946

> Also, you seem to be changing the behavior for those for whom
> /sys/devices/system/cpu/cpu0/cpufreq/scaling_available_governors exists and
> explicitly *start* ondemand rather than using background. It looks to me like
> it's possibly an error in applying the changes to solve the issue you're
> seeing.

"start" just calls the same init script but with the "background" argument so it ends up in the same code path.
-- 
https://code.launchpad.net/~sdeziel/sysvinit/early-exit-ondemand/+merge/254111
Your team Ubuntu branches is subscribed to branch lp:ubuntu/vivid/sysvinit.



More information about the Ubuntu-reviews mailing list