[Merge] lp:~phablet-team/network-manager/lp1435776 into lp:~network-manager/network-manager/ubuntu

[Tony Espy]

Tony Espy has proposed merging lp:~phablet-team/network-manager/lp1435776 into lp:~network-manager/network-manager/ubuntu.

Commit message:
 * debian/patches/lp1435776_rm_ofono_secret_settings.patch: remove code
    that added USERNAME and PASSWORD to NM_SETTING_GSM object.  NM doesn't
    actually need access to these settings, and they can cause issues with
    NM's secrets needed logic.


Requested reviews:
  Network-manager (network-manager)
Related bugs:
  Bug #1435776 in network-manager (Ubuntu): "NM does not activate ofono Inet contexts w/Username but no Password ( eg. giffgaff )"
  https://bugs.launchpad.net/ubuntu/+source/network-manager/+bug/1435776
  Bug #1450790 in network-manager (Ubuntu): "Phone with an APN specifying Username/Password, not re-connecting to mobile data until rebooting"
  https://bugs.launchpad.net/ubuntu/+source/network-manager/+bug/1450790

For more details, see:
https://code.launchpad.net/~phablet-team/network-manager/lp1435776/+merge/258634

This change affects the ofono settings plugin and the way that it configures system connections based on ofono gprs_contexts ( aka APNs ).

The change removes the addition of USERNAME and PASSWORD NM_SETTING_GSM settings to the connection, as they're not needed by network-manager, and can cause secret-related activation errors.

-- 
Your team Ubuntu Phablet Team is subscribed to branch lp:~phablet-team/network-manager/lp1435776.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 2784 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20150508/b39be50e/attachment.diff>