[Merge] lp:~gang65/webbrowser-app/webbrowser-app-keyboard-shortcuts into lp:webbrowser-app

[Ugo Riboni]

Review: Needs Fixing

I noticed the following issues:

1) CTRL+W and CTRL+TAB should work also when the "new tab" page is visible. Right now they do nothing when on that page.

2) CTRL+H shows history, but pressing CTRL+H again on that page will cause the browser to show an empty screen and there is no way to get out of it.

3) As Olivier also mentioned, when pressing ALT+L or CTRL+L the entire text of the address bar should be selected. Add a new function to AddressBar.qml to do this and then another one to Chrome.qml that calls it. Then from Browser.qml call the function exposed by Chrome.qml 

I also would add the following things that are not explicit in the design but they are what most users who are used to keyboard navigation would expect in a browser:

1) CTRL+D should toggle bookmarks, not only add them. This should be the same behaviour as clicking on the bookmark star in the address bar.

2) Pressing ESC should escape the current context:
 - defocus the address bar if it is focused
 - return to the page if any non-page screen is open (history, settings, etc)
Otherwise there is no way to escape these pages once you get to them with the other keyboard shortcuts

3) History navigation has ALT+LEFT and ALT+RIGHT, but tabs navigation has only CTRL+TAB. Intuitively we need also CTRL+SHIFT+TAB to navigate backwards in the list.


-- 
https://code.launchpad.net/~gang65/webbrowser-app/webbrowser-app-keyboard-shortcuts/+merge/249134
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.