[Merge] lp:~unity-team/qtubuntu/DPR into lp:qtubuntu

Daniel d'Andrada daniel.dandrada at canonical.com
Fri May 1 11:15:29 UTC 2015


Review: Needs Fixing

In src/ubuntumirclient/window.cpp:

"""
    DLOG("[ubuntumirclient QPA] creating surface at (%d, %d) with pixel size (%d, %d) with title '%s'\n",
            d->bufferSizePx.x(), d->bufferSizePx.y(), d->bufferSizePx.width(), d->bufferSizePx.height(), title.data());
"""

bufferSizePx has no x() and y() (as it's a QSize, not a QRect). I think code won't build if you enable debug logging?
-- 
https://code.launchpad.net/~unity-team/qtubuntu/DPR/+merge/257515
Your team Ubuntu Phablet Team is subscribed to branch lp:qtubuntu.



More information about the Ubuntu-reviews mailing list