[Merge] lp:~phablet-team/qt-halide/unit-tests into lp:qt-halide

Ugo Riboni ugo.riboni at canonical.com
Tue Mar 31 09:17:37 UTC 2015


> re-23) (rev 288): why adding rendering tests and not simply checking if the 'updating' property went through true [when testing functions with missing buffer and non-buffer input parameters] ?

Because it might update correctly but render incorrectly when there is input missing. 
I want to check that it renders what it should render as well.

>>> In which revision is the following implemented ?
>>  24) tests/unit/tst_function_property_types.qml
> - should check that no type warning is emitted
> - should check that transform is applied

I can only check that warnings *are* emitted, not their absence. Unless you know a way to do that with QML TestCase, in which case I'd like to know.

I added code to check that the transform actually renders using the correct values received by the parameters, because it was not doing anything with them before. What it does with the values is not useful and a bit contrieved, better ideas welcome.
-- 
https://code.launchpad.net/~phablet-team/qt-halide/unit-tests/+merge/254064
Your team Ubuntu Phablet Team is subscribed to branch lp:~phablet-team/qt-halide/unit-tests.



More information about the Ubuntu-reviews mailing list