[Merge] lp:~rpadovani/webbrowser-app/settings-page into lp:webbrowser-app

Olivier Tilloy olivier.tilloy at canonical.com
Tue Mar 31 08:54:52 UTC 2015


Review: Needs Fixing

201	+                subText: settingsObject.searchEngine

this is the filename (minus the .xml extension), not very user friendly. Instead, the subtext should have the display name of the engine, for which we need to instantiate a SearchEngine object:

    SearchEngine {
        id: currentSearchEngine
        filename: settingsObject.searchEngine
    }
    subText: currentSearchEngine.name
-- 
https://code.launchpad.net/~rpadovani/webbrowser-app/settings-page/+merge/253975
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list