[Merge] lp:~abreu-alexandre/webbrowser-app/remove-qtwebkit-deps into lp:webbrowser-app

Olivier Tilloy olivier.tilloy at canonical.com
Fri Mar 27 18:00:17 UTC 2015


Review: Needs Fixing

Looks good, thanks for doing this!
A few minor fixes:

 - as pointed by Timo, please revert the changes to debian/changelog

 - getQtWebkitDpr() should be removed from src/Ubuntu/Web/plugin.cpp

 - src/Ubuntu/Components/Extras/Browser/hyperlinks.js should be removed

 - src/Ubuntu/Components/Extras/Browser/ua-overrides.js should be removed

 - description of qtdeclarative5-ubuntu-ui-extras-browser-plugin in debian/control should be updated to remove the mention of version 0.1 of the module

 - currentArchitecturePathName() should be removed from src/app/webcontainer/webapp-container.cpp
-- 
https://code.launchpad.net/~abreu-alexandre/webbrowser-app/remove-qtwebkit-deps/+merge/254291
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list