[Merge] lp:~phablet-team/qt-halide/unit-tests into lp:qt-halide

Florian Boucault florian.boucault at canonical.com
Wed Mar 25 12:22:48 UTC 2015


Review: Needs Fixing

1) Add README with how to run tests & get coverage
2) Why is it needed to manually call wipe-coverage?
3) Where did you get cmake/QmlTest.cmake, cmake/QmlPlugins.cmake, cmake/ParseArguments.cmake, cmake/Findgcovr.cmake, cmake/FindLcov.cmake, cmake/EnableCoverageReport.cmake from? Aren't they packaged up somewhere?
4) There should really be no changes to backend/modules/Filters, instead backend/tests should grow its own QML plugin
-- 
https://code.launchpad.net/~phablet-team/qt-halide/unit-tests/+merge/254064
Your team Ubuntu Phablet Team is subscribed to branch lp:~phablet-team/qt-halide/unit-tests.



More information about the Ubuntu-reviews mailing list