[Merge] lp:~rpadovani/webbrowser-app/newTabRefactoring into lp:webbrowser-app

Riccardo Padovani riccardo at rpadovani.com
Mon Mar 23 08:41:44 UTC 2015


We discussed about this on IRC, but I left a comment here as future reference.

I found a couple of bugs with limitedlistview:

-  it doesn't emit a signal when the number of bookmarks change so if you have 5 bookmarks, open a new page, bookmark it, and then return to the new tab view, there isn't the button 'show more'. But there is if you open a *new* new tab

- If I place the limitedlistview in a column, how we discussed, there is a strange bug when you remove an element: let's say the model has 6 elements and the limit is 5: column contentHeight is limitedlistview.delegate * 5, as it should be. When I remove an element, the column contentHeight becomes limitedlistview.delegate * 4, while it should remain * 5. Since the limitedlistview isn't the only element in the column, forcing the contentHeight of the column is difficult and require a lot of ugly code
-- 
https://code.launchpad.net/~rpadovani/webbrowser-app/newTabRefactoring/+merge/247498
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list