[Merge] lp:~phablet-team/qtubuntu-media/media-hub-3-changes into lp:qtubuntu-media
Jim Hodapp
jim.hodapp at canonical.com
Mon Mar 16 20:04:26 UTC 2015
Jim Hodapp has proposed merging lp:~phablet-team/qtubuntu-media/media-hub-3-changes into lp:qtubuntu-media.
Commit message:
* Make necessary adaptations for media-hub-3 interface changes.
* Make sure video plays any number of times after hitting the end of stream.
* Don't continue to receive frame_available callbacks after the AalVideoRendererControl instance is destroyed.
* Don't crash in the unit tests if m_frameAvailableConnection hasn't been instantiated, also making sure it's connected to the signal before disconnecting it.
* Fix the point srubbing EOS case (tap right at the end of the stream on the timeline).
* Only reset the video sink if we are playing video.
* Don't load anything related to the video renderer control if we are playing audio only.
Requested reviews:
Ubuntu Phablet Team (phablet-team)
For more details, see:
https://code.launchpad.net/~phablet-team/qtubuntu-media/media-hub-3-changes/+merge/253105
* Make necessary adaptations for media-hub-3 interface changes.
* Make sure video plays any number of times after hitting the end of stream.
* Don't continue to receive frame_available callbacks after the AalVideoRendererControl instance is destroyed.
* Don't crash in the unit tests if m_frameAvailableConnection hasn't been instantiated, also making sure it's connected to the signal before disconnecting it.
* Fix the point srubbing EOS case (tap right at the end of the stream on the timeline).
* Only reset the video sink if we are playing video.
* Don't load anything related to the video renderer control if we are playing audio only.
--
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~phablet-team/qtubuntu-media/media-hub-3-changes into lp:qtubuntu-media.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 20371 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20150316/8a699eec/attachment-0001.diff>
More information about the Ubuntu-reviews
mailing list