[Merge] lp:~gang65/webbrowser-app/webbrowser-app-keyboard-shortcuts into lp:webbrowser-app
Olivier Tilloy
olivier.tilloy at canonical.com
Mon Mar 16 07:19:26 UTC 2015
That looks good, thanks for the updates.
One question:
51 + if (bookmarksModel.contains(currentWebview.url)) {
52 + bookmarksModel.remove(currentWebview.url)
53 + }
54 + bookmarksModel.add(currentWebview.url, currentWebview.title, currentWebview.title)
Do you really mean to remove the bookmark and re-add it right away if the page was already bookmarked? Shouldn’t Ctrl+D toggle the bookmark status of the page?
--
https://code.launchpad.net/~gang65/webbrowser-app/webbrowser-app-keyboard-shortcuts/+merge/249134
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.
More information about the Ubuntu-reviews
mailing list