[Merge] lp:~renatofilho/address-book-app/sim-card-import into lp:address-book-app

Bill Filler bill.filler at canonical.com
Wed Mar 11 18:53:26 UTC 2015


> > 2 things need to be fixed:
> >
> > 1) I discussed with Olga about the "ME" avatar. Since we don't have a good
> > translation story, for now we should switch this to use a label instead. The
> > label should say "My phone number:" with the phone number listed to the
> right
> > of it
> What should be appear when I have more then one sim? Should I show different
> entries for each SIM? Or show a phone number list in the same entry?

I would show multiple entries if there are more than one SIM like:
My phone number (SIM1): xxx-xxx-xxx-xxx
My phone number (SIM2): xxx-xxx-xxx-xxx-

If only one sim, then don't show the SIM1 label but just:
My phone number: xxx-xxx-xxx

> 
> >
> > 2) We need to check if the SIM is locked and display a message to the user,
> > similar to how dialer and messaging-app do it. They display a dialog with a
> > message and a link to unlock. We should do the same thing when the user
> clicks
> > "Import contacts from SIM card" on the settings or empty list page.
> Currently
> > we just show the message "SIM card is empty" which is misleading.
> 
> What should be the behavior if only one of the SIM card is blocked? Should I
> show the contacts for the unlocked ones? Or should I show the message to
> unlock the SIM?

You should show the unlocked ones and also show a message indicating that one of the sims is locked.

-- 
https://code.launchpad.net/~renatofilho/address-book-app/sim-card-import/+merge/248562
Your team Ubuntu Phablet Team is subscribed to branch lp:address-book-app.



More information about the Ubuntu-reviews mailing list