[Merge] lp:~renatofilho/address-book-app/sim-card-import into lp:address-book-app
Bill Filler
bill.filler at canonical.com
Mon Mar 9 15:18:20 UTC 2015
Review: Needs Fixing
2 things need to be fixed:
1) I discussed with Olga about the "ME" avatar. Since we don't have a good translation story, for now we should switch this to use a label instead. The label should say "My phone number:" with the phone number listed to the right of it
2) We need to check if the SIM is locked and display a message to the user, similar to how dialer and messaging-app do it. They display a dialog with a message and a link to unlock. We should do the same thing when the user clicks "Import contacts from SIM card" on the settings or empty list page. Currently we just show the message "SIM card is empty" which is misleading.
--
https://code.launchpad.net/~renatofilho/address-book-app/sim-card-import/+merge/248562
Your team Ubuntu Phablet Team is subscribed to branch lp:address-book-app.
More information about the Ubuntu-reviews
mailing list