[Merge] lp:~renatofilho/address-book-app/sim-card-import into lp:address-book-app

[Renato Araujo Oliveira Filho]

> A few issues:
> 
> 1) The label on contact list page should say "Import contacts from SIM card"
> not "Import contacts from sim card"
Fixed on rev. 397

> 2) There is currently a toolbar button (with arrow) on the first time contact
> list page (i.e. the page that displays "Import from Google", "Import from SIM
> card"). We should not show the toolbar button here as there is already an
> option in the list
Fixed on rev. 394

> 3) The header title when doing import from sim should say "Import SIM
> Contacts" I think, as there is no indication where these are coming from
Fixed on rev. 395

> 4) What happens in the dual-sim case if you have contacts on both sims? Does
> the view show all of them combined? (I would expect it to)
Yes both contact list is showed as one list.

> 5) Is there a better icon we could get perhaps? This one looks like a
> Download/Save button to me
I am no happy with this icon, but I did not find any better icon.
I reported a bug some time ago about that: https://bugs.launchpad.net/ubuntu-themes/+bug/1424819

> 6) Wondering if we should always have the toolbar icon in a drawer? Whether
> it's by itself or with a sync button. This way we have text to describe what
> the action is and the icon becomes less import. Once we have settings we'll
> need a drawer probably anyay
this is a SDK component, the drawer appears automatically if we have more then 4 buttons (back on the left, more 3 on the right) this is not an application property.
And Olga told me that the import functionality is going to be moved to application settings, because this is an action that the user will do once.



-- 
https://code.launchpad.net/~renatofilho/address-book-app/sim-card-import/+merge/248562
Your team Ubuntu Phablet Team is subscribed to branch lp:address-book-app.