[Merge] lp:~jamesodhunt/ubuntu/vivid/ubuntu-core-upgrader/add-more-tests into lp:ubuntu/ubuntu-core-upgrader

[James Hunt]

James Hunt has proposed merging lp:~jamesodhunt/ubuntu/vivid/ubuntu-core-upgrader/add-more-tests into lp:ubuntu/ubuntu-core-upgrader.

Requested reviews:
  Michael Vogt (mvo)

For more details, see:
https://code.launchpad.net/~jamesodhunt/ubuntu/vivid/ubuntu-core-upgrader/add-more-tests/+merge/251571

This branch adds a few more unit tests, but also adds in a bit of infrastructure to allow my original functional tests (which call /usr/bin/ubuntu-core-upgrader directly) to be reworked and added as unit tests (via a follow-on MP).


  * bin/ubuntu-core-upgrade:
    - parse_args(): Return a dict for easier testing.
    - Update for options dict.
  * ubuntucoreupgrader/tests/test_upgrader.py:
    - More tar_generator() tests.
    - Added first Upgrader() object test.
  * ubuntucoreupgrader/upgrader.py:
    - Comments.
    - tar_generator():
      - Fix to allow '--root-dir' to work again.
      - Fix bug where path not set (only affecting tests).
    - Updates for accessing self.options dict.
    - Assert root_dir option set.

-- 
Your team Ubuntu branches is subscribed to branch lp:ubuntu/ubuntu-core-upgrader.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 34858 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20150303/6f18e0d3/attachment-0001.diff>