[Merge] lp:~boiko/telephony-service/dynamic_supported_protocols into lp:telephony-service

Gustavo Pichorim Boiko gustavo.boiko at canonical.com
Tue Jun 16 13:30:02 UTC 2015


> > The code looks good, but I think it would be good to use a
> > QFileSystemWatcher() to monitor the protocols directory and reload the
> > configuration on demand. The user could install a 3rd party plugin/protocol
> > and wish to use it without restarting the apps. (I suppose dialer/messaging-
> > apps would be notified about the new account, but ProtocolManager would
> still
> > return the protocol/features are not supported.
> > What do you think?
> 
> So, dialer and messaging wouldn't be notified about the new account, because
> accounts are filtered using the supported protocols. But indeed it is a good
> idea to monitor for new supported protocols.

Actually, if they were started after the new protocol is added, dialer and messaging would see the new accounts and handler/indicator/etc would not, so your initial comment is indeed correct.
-- 
https://code.launchpad.net/~boiko/telephony-service/dynamic_supported_protocols/+merge/261758
Your team Ubuntu Phablet Team is subscribed to branch lp:telephony-service.



More information about the Ubuntu-reviews mailing list