[Merge] lp:~dannf/ubuntu/wily/grub2-signed/arm64-support into lp:ubuntu/grub2-signed
dann frazier
dann.frazier at canonical.com
Mon Jun 15 21:52:38 UTC 2015
Review: Resubmit
> You should never use "dpkg --print-architecture" to determine the arch you're
> building FOR. What you're looking for (in both places) is dpkg-architecture
> -qDEB_HOST_ARCH
Fixed.
> Other oddities:
>
> 1) Why do we need .install files when we didn't seem to before?
It is just how I chose to handle the single-binary -> multi-binary conversion. But it does seem like a pain to have to add that file for every new architecture. I switched this to just overriding destdir during install.
> 2) symlinking to arch-specific bits in clean doesn't seem clever, you'll get
> different source cruft depending on the arch you clean/upload on.
Fixed.
--
https://code.launchpad.net/~dannf/ubuntu/wily/grub2-signed/arm64-support/+merge/259667
Your team Ubuntu branches is subscribed to branch lp:ubuntu/grub2-signed.
More information about the Ubuntu-reviews
mailing list