[Merge] lp:~phablet-team/network-manager/lp1461593 into lp:~phablet-team/network-manager/vivid-phone-overlay

[Tony Espy]

Tony Espy has proposed merging lp:~phablet-team/network-manager/lp1461593 into lp:~phablet-team/network-manager/vivid-phone-overlay.

Commit message:
  debian/patches/lp1461593-add-modem-reconnect-delay.patch: add
  a 5s delay to NM_POLICY's activation logic triggered when a
  device is disconnected.  This allows the modem time to settle
  and NM to process the resulting DBus state changes (LP: #1461593).


Requested reviews:
  Alfonso Sanchez-Beato (alfonsosanchezbeato)
Related bugs:
  Bug #1461593 in network-manager (Ubuntu): "No data connection switching from 2G only to 3G"
  https://bugs.launchpad.net/ubuntu/+source/network-manager/+bug/1461593

For more details, see:
https://code.launchpad.net/~phablet-team/network-manager/lp1461593/+merge/261450

This change adds a 5s delay into NM_POLICY's re-connect logic, specifically so that the retry_limit of the associated connection isn't exhausted immediately whenever the connection drops, which then used to result in a 5m timer being set.

There are two changes...

1. The afore-mentioned 5m timer is now reduced to 30s for modem devices. In theory, connections shouldn't be getting disabled anymore due to the above fix, so this is a just-in-case change.

2. The low-level NM_MODEM_OFONO code wasn't setting the modem state to DISCONNECTING when disconnect() was called.  This is now done, and in the associated callback ( disconnect_cb ) the new state is now determined by the ofono cached properties ( online && powered && attached ).
-- 
Your team Ubuntu Phablet Team is subscribed to branch lp:~phablet-team/network-manager/vivid-phone-overlay.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 11639 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20150608/651afb2f/attachment.diff>