[Merge] lp:~albaguirre/qtubuntu/use-mir-surface-apis into lp:qtubuntu

Alberto Aguirre alberto.aguirre at canonical.com
Fri Jul 31 00:15:42 UTC 2015


>+void UbuntuWindowPrivate::setSurfaceState(Qt::WindowState new_state)
>+{
>+ mir_wait_for(mir_surface_set_state(surface->mirSurface(), >qtWindowStateToMirSurfaceState(new_state)));
>Does this need to be sync?

As in does the call really need to wait for the wait handle? or call a mir_surface_set_state_sync api? (which does not exist in any case)

In any case the wait for set_state is pre-existing, so I didn't change it.

The rest should be fixed now.
-- 
https://code.launchpad.net/~albaguirre/qtubuntu/use-mir-surface-apis/+merge/262257
Your team Ubuntu Phablet Team is subscribed to branch lp:qtubuntu.



More information about the Ubuntu-reviews mailing list