[Merge] lp:~artmello/webbrowser-app/webbrowser-app-history_view_convergence into lp:webbrowser-app

[Olivier Tilloy]

Review: Needs Fixing

Current item highlight in the right panel should probably not be visible when the left panel has active focus (so that it’s obvious where the active focus currently is).

38	+        sourceComponent: browser.width < units.gu(90) ? historyViewComponent : historyViewLandscapeComponent
The Browser component has a 'wide' property that you should use to avoid hardcoding a 90GU threshold.

Can the HistoryViewLandscape component be renamed to "HistoryViewWide"?

Can you add QML unit tests for this new component?

I’m seeing a weird functional issue: with a history DB that has entries for many different dates (so the left panel can scroll), if I press the Down arrow key and keep it pressed the panel will scroll all the way to the bottom as expected. If I then press the Up arrow key and keep it pressed, the panel is not scrolled all the way to the top (although the first entry, "All Days", is correctly selected, but it’s not in view).
-- 
https://code.launchpad.net/~artmello/webbrowser-app/webbrowser-app-history_view_convergence/+merge/263052
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.