[Merge] lp:~jin.cth/webbrowser-app/webbrowser-app into lp:webbrowser-app
Jin
jin.hsieh at canonical.com
Thu Jul 30 05:12:03 UTC 2015
Thanks for your reminder,
I gave the suggestion API a fix,
and checked it working fine by PC browser locally.
(it means the access which does not be blocked by GFW)
But a defect here,
still can not see the suggestion on phone target,
because the returned result from Baidu is not a regular format,
it has its own prefix.
For example,
we can get the result from yahoo by:
https://search.yahoo.com/sugg/ff?output=fxjson&command=test
and the result is like this:
["test",["testosterone",...,"testicular pain"],[],[]]
which is a normal one, but for Baidu,
http://suggestion.baidu.com/su?wd=wq&p=3&cb=firefox.bdsug.sug
then result will be:
firefox.bdsug.sug({q:"wq",p:false,s:["爸爸去哪儿第三季",...,"网球优等生"]});
the term "q:...s:" is not a regular json format here,
it leads the search bar show nothing to user.
My suggestion is I still submit the MP with modified API,
and open a bug to do the tracking on this issue,
what do you think..?
BR.
Jin
--
https://code.launchpad.net/~jin.cth/webbrowser-app/webbrowser-app/+merge/266209
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~jin.cth/webbrowser-app/webbrowser-app into lp:webbrowser-app.
More information about the Ubuntu-reviews
mailing list