[Merge] lp:~artmello/gallery-app/gallery-app-fix_crash_adding_files into lp:gallery-app

Gustavo Pichorim Boiko gustavo.boiko at canonical.com
Thu Jul 23 20:22:00 UTC 2015


Review: Needs Fixing

Just one remark, but other than that the code looks good

Diff comments:

> === modified file 'rc/qml/OrganicView/OrganicMediaList.qml'
> --- rc/qml/OrganicView/OrganicMediaList.qml	2015-03-27 23:12:41 +0000
> +++ rc/qml/OrganicView/OrganicMediaList.qml	2015-07-23 20:11:49 +0000
> @@ -183,6 +185,7 @@
>  
>                  Connections {
>                      target: model.mediaSource
> +                    ignoreUnknownSignals: true

Maybe instead of setting ignoreUnknownSignals, you can:
target: model && model.mediaSource ? model.mediaSource : null

>                      onDataChanged: {
>                          // data changed but filename didn't, so we need to bypass the qml image
>                          // cache by tacking a timestamp to the filename so sees it as different.


-- 
https://code.launchpad.net/~artmello/gallery-app/gallery-app-fix_crash_adding_files/+merge/265731
Your team Ubuntu Phablet Team is subscribed to branch lp:gallery-app.



More information about the Ubuntu-reviews mailing list