[Merge] lp:~boiko/telephony-service/do_not_accept_outgoing_channels into lp:telephony-service

[Tiago Salem Herrmann]

Review: Needs Fixing

Just one small remark.
Looks good otherwise.

Diff comments:

> 
> === modified file 'tests/common/mock/callchannel.cpp'
> --- tests/common/mock/callchannel.cpp	2015-07-17 18:18:57 +0000
> +++ tests/common/mock/callchannel.cpp	2015-07-23 02:52:08 +0000
> @@ -89,17 +89,19 @@
>      mIncoming = mState == "incoming" || mState == "waiting";
>  
>      identifiers[mTargetHandle] = mPhoneNumber;
> +
>      reason.actor =  0;
>      reason.reason = Tp::CallStateChangeReasonProgressMade;
>      reason.message = "";
>      reason.DBusReason = "";
> +
>      if (mIncoming) {
>          memberFlags[mTargetHandle] = 0;
>      } else {
>          memberFlags[mTargetHandle] = Tp::CallMemberFlagRinging;
>      }
>  
> -    mCallChannel->setCallState(Tp::CallStateInitialising, 0, reason, stateDetails);
> +    setCallState("initializing");

Just to keep consistency with telepathy, can we rename the states to "initialising" and "initialised" ?

>  
>      mCallContent = Tp::BaseCallContent::create(baseChannel()->dbusConnection(), baseChannel().data(), "audio", Tp::MediaStreamTypeAudio, Tp::MediaStreamDirectionNone);
>  


-- 
https://code.launchpad.net/~boiko/telephony-service/do_not_accept_outgoing_channels/+merge/265606
Your team Ubuntu Phablet Team is subscribed to branch lp:telephony-service.