[Merge] lp:~gary-wzl77/qtorganizer5-eds/fix_1445577 into lp:qtorganizer5-eds
Renato Araujo Oliveira Filho
renato.filho at canonical.com
Thu Jul 23 12:53:27 UTC 2015
Review: Needs Information
Reading the bug report I would say that the event is losing the timezone when edited. Is the app setting the correct timezone? If the app does not set the timezone the event will be handled as a Floating event.
Diff comments:
> === modified file 'organizer/qorganizer-eds-engine.cpp'
> --- organizer/qorganizer-eds-engine.cpp 2015-05-08 20:01:32 +0000
> +++ organizer/qorganizer-eds-engine.cpp 2015-07-12 03:47:33 +0000
> @@ -1224,9 +1225,7 @@
> return QDateTime::fromTime_t(tmTime, qTz);
> } else {
> tmTime = icaltime_as_timet(value);
> - QDateTime t = QDateTime::fromTime_t(tmTime).toUTC();
> - // floating time contains invalid timezone
> - return QDateTime(t.date(), t.time(), QTimeZone());
> + return QDateTime::fromTime_t(tmTime).toUTC();
Did you test alarms?
This code was created for alarms which are floating time events (events that does not follow the timezone, a event created at 8:00 AM will fired at 8:00 AM does not matter if you change your timezone).
> }
> }
>
--
https://code.launchpad.net/~gary-wzl77/qtorganizer5-eds/fix_1445577/+merge/264489
Your team Ubuntu Phablet Team is subscribed to branch lp:qtorganizer5-eds.
More information about the Ubuntu-reviews
mailing list