[Merge] lp:~artmello/webbrowser-app/webbrowser-app-history_view_convergence into lp:webbrowser-app

Bill Filler bill.filler at canonical.com
Wed Jul 15 19:13:02 UTC 2015


Review: Needs Fixing

Couple of issues:

1) The section labels are a bit confusing. When "All Days" is selected on the left, the first section on the right should say "Today" but it currently says "Last Visited" which is confusing.

2) When "Today" is selected on the left the section on the right should say "Today" as well, not "Last Visited"

3) As we are not supporting "Recently Closed" yet, I think we should change the main heading on the page to say "History" rather than "Last Visited" as I think the later is kind of confusing.

4) If I select a date on the left panel, then press and hold, select all, then delete. The date on the left panel is correctly removed. Currently the selection moves to the date beneath the one deleted but the list of history is not correct - it shows the entries that were deleted. Changing selection does not seem to fix it - you end up with blank history for the entry selected after deleting. It doesn't get fixed until you close the view and reopen. Actually seems the index is off by one. Selecting the next one from the list shows the proper results. We should do one of the following:
- after delete, select the "All Days" and make sure the results are correct or
- after delete, select the next date in the list (or previous date if it's the last one in the list deleted) and make sure it's results are correct

5) Keyboard navigation
- up/down arrows should navigate up/down through the left panel when selected and right panel when selected
- the right arrow/left arrow should navigate between the panels

6) Scrollbars
Is there anything automatic in the SDK that will display scrollbars for both panels? not seeing any scrollbars but would expect to when mouse plugged in
-- 
https://code.launchpad.net/~artmello/webbrowser-app/webbrowser-app-history_view_convergence/+merge/263052
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list