[Merge] lp:~tiagosh/telepathy-ofono/move-pulse-to-thread into lp:telepathy-ofono

Gustavo Pichorim Boiko gustavo.boiko at canonical.com
Tue Jul 14 18:16:27 UTC 2015


Review: Needs Fixing

344	+    QObject::connect(mWorker, SIGNAL(audioModeChanged(const AudioMode)), this, SIGNAL(audioModeChanged(const AudioMode)));
345	+    QObject::connect(mWorker, SIGNAL(availableAudioModesChanged(const AudioModes)), this, SIGNAL(availableAudioModesChanged(const AudioModes)));

Can you just make it explicit that this is a Qt::QueuedConnection?
-- 
https://code.launchpad.net/~tiagosh/telepathy-ofono/move-pulse-to-thread/+merge/264743
Your team Ubuntu Phablet Team is subscribed to branch lp:telepathy-ofono.



More information about the Ubuntu-reviews mailing list