[Merge] lp:~artmello/webbrowser-app/webbrowser-app-history_view_convergence into lp:webbrowser-app

[Riccardo Padovani]

> I personally believe that the sections here would be inconsistent since they
> would be only visible for the "All days" entry. Let me know if with the "All
> days" entry and the highlights you think this is still necessary.

Definitely better now, indeed I don't think is necessary anymore.

> > - There is no way to return to that view, I think you should add an 'All
> days'
> > label or similar
> 
> I agree with you and added the "All days" entry, let me know what you think.
> But, that is not in the design specification for this feature so we would need
> to show it to design team and look for their approval. I personally think it
> makes sense having this entry.

I'm sure designers will agree with us ;-)

> > - When I visite a site it goes in the 'Yesterday' label, not in today
> 
> I am not able to reproduce that any more after the last changes, let me know
> if that is still an issue to you.

Me neither indeed

> There are still some issues with keyboard shortcuts so far, I am still working
> on a fix for that.

I see you did some other commits after you wrote this reply, so I assume you fix that. If not, sorry for the next comments:
- In a new tab if you click the back button then the CTRL+H shortcut doesn't work
- I suggest to add ctrl+click shortcut: if I press an history element while I'm clicking CTRL I expect to have the new tab opened in the background
- If I try to delete an element the red trash goes over the left column


I didn't check the code yet, sorry but I'm busy with uni atm, so maybe my replies will be late
-- 
https://code.launchpad.net/~artmello/webbrowser-app/webbrowser-app-history_view_convergence/+merge/263052
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~artmello/webbrowser-app/webbrowser-app-history_view_convergence into lp:webbrowser-app.