[Merge] lp:~boiko/telephony-service/sync_ota5_fixes into lp:telephony-service

[Gustavo Pichorim Boiko]

Gustavo Pichorim Boiko has proposed merging lp:~boiko/telephony-service/sync_ota5_fixes into lp:telephony-service.

Commit message:
Sync the fixes that were released in OTA5:

  [ Andreas Pokorny ]
  * sbuild fix

  [ Gustavo Pichorim Boiko ]
  * Do not update the pot file automatically on builds, it causes
    conflicts when multiple changes are applied together.

  [ Iain Lane ]
  * We don't inherit from the 'gnome' icon theme any more, so our icons
    weren't being found in a default Unity session using ubuntu-mono-
    dark. We do, however, inherit from Humanity, so put the icons under
    this theme. (LP: #1412709)

  [ Sebastien Bacher ]
  * Don't play keypad sounds in silentmode (LP: #1384274)
  * don't unref a non owned variant, g_variant_new_strv() returns a
    floating reference which is consumed by calling
    messaging_menu_message_add_action() thanks Lars Uebernickel for
    pointing the issue (LP: #1427286)

  [ Tiago Salem Herrmann ]
  * Check if targetContact() returns a valid pointer before using it.
    (LP: #1433068)

  [ Gustavo Pichorim Boiko ]
  * Prevent telephony-service from auto-accepting calls in the case of
    an approver failure. added: tests/approver/
    tests/approver/ApproverTest.cpp tests/approver/CMakeLists.txt
    tests/approver/approvercontroller.cpp
    tests/approver/approvercontroller.h

  [ Tiago Salem Herrmann ]
  * Do not let USSD and incoming call snap decisions timeout. Initialize
    m_notificationId with -1, as 0 is a valid id. Do not call
    CloseNotification() when notificationClosed() is received to avoid
    loop. (LP: #1453004)

Requested reviews:
  Ubuntu Phablet Team (phablet-team)
Related bugs:
  Bug #1384274 in telephony-service (Ubuntu): "silent mode doesn't silence keyboard or dialpad"
  https://bugs.launchpad.net/ubuntu/+source/telephony-service/+bug/1384274
  Bug #1412709 in notify-osd (Ubuntu): "Error: loading icon 'notification-notification-audio-volume-medium' caused error: 'Icon 'notification-notification-audio-volume-medium' not present in theme'"
  https://bugs.launchpad.net/ubuntu/+source/notify-osd/+bug/1412709
  Bug #1427286 in telephony-service (Ubuntu): "g_variant_unref warning displayed when calling back after a missed call "
  https://bugs.launchpad.net/ubuntu/+source/telephony-service/+bug/1427286
  Bug #1433068 in telephony-service (Ubuntu): "/usr/bin/unity8:11:QString:Tp::Contact::id:CallEntry::phoneNumber:CallEntry::qt_metacall:Direct"
  https://bugs.launchpad.net/ubuntu/+source/telephony-service/+bug/1433068
  Bug #1453004 in Canonical System Image: "Phone is ringing but no sliders to pick up the call are presented"
  https://bugs.launchpad.net/canonical-devices-system-image/+bug/1453004

For more details, see:
https://code.launchpad.net/~boiko/telephony-service/sync_ota5_fixes/+merge/264207

Sync the fixes that were released in OTA5:

  [ Andreas Pokorny ]
  * sbuild fix

  [ Gustavo Pichorim Boiko ]
  * Do not update the pot file automatically on builds, it causes
    conflicts when multiple changes are applied together.

  [ Iain Lane ]
  * We don't inherit from the 'gnome' icon theme any more, so our icons
    weren't being found in a default Unity session using ubuntu-mono-
    dark. We do, however, inherit from Humanity, so put the icons under
    this theme. (LP: #1412709)

  [ Sebastien Bacher ]
  * Don't play keypad sounds in silentmode (LP: #1384274)
  * don't unref a non owned variant, g_variant_new_strv() returns a
    floating reference which is consumed by calling
    messaging_menu_message_add_action() thanks Lars Uebernickel for
    pointing the issue (LP: #1427286)

  [ Tiago Salem Herrmann ]
  * Check if targetContact() returns a valid pointer before using it.
    (LP: #1433068)

  [ Gustavo Pichorim Boiko ]
  * Prevent telephony-service from auto-accepting calls in the case of
    an approver failure. added: tests/approver/
    tests/approver/ApproverTest.cpp tests/approver/CMakeLists.txt
    tests/approver/approvercontroller.cpp
    tests/approver/approvercontroller.h

  [ Tiago Salem Herrmann ]
  * Do not let USSD and incoming call snap decisions timeout. Initialize
    m_notificationId with -1, as 0 is a valid id. Do not call
    CloseNotification() when notificationClosed() is received to avoid
    loop. (LP: #1453004)
-- 
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~boiko/telephony-service/sync_ota5_fixes into lp:telephony-service.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 36975 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20150708/9179677a/attachment-0001.diff>