[Merge] lp:~rpadovani/webbrowser-app/no-duplicates-address-bar into lp:webbrowser-app
Olivier Tilloy
olivier.tilloy at canonical.com
Mon Jul 6 17:25:25 UTC 2015
Counting how many items you’ve added from one given model is okay. What’s not ok is to check that with hardcoded assertions such as:
model.icon !== 'non-starred'
because you make assumptions on the models used to populate the suggestions.
--
https://code.launchpad.net/~rpadovani/webbrowser-app/no-duplicates-address-bar/+merge/262586
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.
More information about the Ubuntu-reviews
mailing list