[Merge] lp:~tiagosh/telephony-service/fix-1433068 into lp:telephony-service/rtm-15.04

Gustavo Pichorim Boiko gustavo.boiko at canonical.com
Mon Jul 6 16:21:28 UTC 2015


Gustavo Pichorim Boiko has proposed merging lp:~tiagosh/telephony-service/fix-1433068 into lp:telephony-service/rtm-15.04.

Commit message:
Check if targetContact() returns a valid pointer before using it.

--Checklist--
Are there any related MPs required for this MP to build/function as expected? Please list.
No

Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)
Yes

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?
Yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/<package-name>) on device or emulator?
Yes

If you changed the UI, was the change specified/approved by design?
N/A

If you changed UI labels, did you update the pot file?
N/A

If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP?
N/A

Requested reviews:
  Gustavo Pichorim Boiko (boiko)
  PS Jenkins bot (ps-jenkins): continuous-integration
Related bugs:
  Bug #1433068 in telephony-service (Ubuntu): "/usr/bin/unity8:11:QString:Tp::Contact::id:CallEntry::phoneNumber:CallEntry::qt_metacall:Direct"
  https://bugs.launchpad.net/ubuntu/+source/telephony-service/+bug/1433068

For more details, see:
https://code.launchpad.net/~tiagosh/telephony-service/fix-1433068/+merge/263930

Check if targetContact() returns a valid pointer before using it.
-- 
Your team Ubuntu Phablet Team is subscribed to branch lp:telephony-service/rtm-15.04.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 572 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20150706/7a4a0a6e/attachment.diff>


More information about the Ubuntu-reviews mailing list