[Merge] lp:~rpadovani/webbrowser-app/no-duplicates-address-bar into lp:webbrowser-app
Olivier Tilloy
olivier.tilloy at canonical.com
Mon Jul 6 11:16:08 UTC 2015
Review: Needs Fixing
Thanks for the bug report, and for working on a fix, Riccardo!
While the patch kind of works, the approach isn’t right, as it special-cases bookmarks in a component (Suggestions.qml) that is generic (it doesn’t know anything about the models populating it).
The approach to remove doublons is ok, but the code should remain generic. Not sure what the best approach for that would be. Maybe add a "displayLimit" parameter to the models, so that e.g. a LimitProxyModel would fetch 4 (or 5, or 10) items, but then only the first 2 that are not doublons would be displayed?
--
https://code.launchpad.net/~rpadovani/webbrowser-app/no-duplicates-address-bar/+merge/262586
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.
More information about the Ubuntu-reviews
mailing list